oh I seeeee.... in my defence I'm still in bed and curtains are shut! :x:


On 27 December 2013 10:02, Paul Blundell <notifications@github.com> wrote:

> In app/src/main/java/uk/co/ataulm/mijur/app/gallery/GalleryActivity.java:
>
> > @@ -34,6 +39,23 @@ private void setupGrid() {
> >      }
> >
> >      @Override
> > +    public boolean onCreateOptionsMenu(Menu menu) {
> > +        MenuInflater inflater = getMenuInflater();
> > +        inflater.inflate(R.menu.gallery, menu);
> > +        return true;
> > +    }
> > +
> > +    @Override
> > +    public boolean onOptionsItemSelected(MenuItem item) {
> > +        switch (item.getItemId()) {
> > +            case R.id.menu_item_refresh:
> > +                getLoaderManager().restartLoader(0, null, loaderCallbacks);
>
> this method should return true or false in the case of if you have dealt
> with the selection. When you hit the switch case of refresh, you have
> explicitly dealt with the selection by restarting the loader and therfore
> you should return true. Currently it drops into the default case and allows
> the system to also handle the selection, what do you expect the system to
> do extra that you want?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ataulm/mijur/pull/20/files#r8565926>
> .
>