Backported patch from [#4762]

URL fragments should not have safe characters escaped. Ref: Appendix A,
  http://tools.ietf.org/rfc/rfc3986.txt

Signed-off-by: José Valim <jose.valim@gmail.com>
Don't remove scheduled destroys when loading an association.

Signed-off-by: José Valim <jose.valim@gmail.com>
fisting Session::AbstractStore#clear to actually clear the session. [#5030 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Use bind instead of instance_exec cause it may be causing memory leaks. Also, provide a simpler and sane implementation for scoped. [#5044 state:resolved]
add missing require to ActiveRecord "base_test.rb"

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
test that ActiveRecord `destroy` and `destroy_all` return destroyed records

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
fixes #2362, eager loading :through associations will join the :source model if there are :conditions

Signed-off-by: José Valim <jose.valim@gmail.com>
Fix the #using_limitable_reflections? helper to work correctly by not examining the length of an array which contains false/true, hence always passing.

Signed-off-by: José Valim <jose.valim@gmail.com>
A generated plugin's test are not run by 'rake test'

Signed-off-by: José Valim <jose.valim@gmail.com>
Set destroyed=true in opt locking's destroy [#5058 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
Sessions should not be created until written to and session data should be destroyed on reset. [#4938 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
fixing performance regression from 2.3.5 -> 2.3.8
Only skip eager loading the code if dependency_loading is still enabled.

Otherwise rake tasks which depend on environment will get errors about missing constants.
backporting a couple missing files.  sorry folks!
Fix for integration tests not serializing arrays in multipart forms correctly.

Signed-off-by: wycats <wycats@gmail.com>
changing fixtures back to superclass_delegating_accessor until we can convert them to class_attributes
update_attribute and updated_attributes! are now wrapped in a transaction

[#922 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
renaming test name to fix accidently override [#5076 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
Changes the usage of Object#returning with Object#tap

Signed-off-by: José Valim <jose.valim@gmail.com>
Deprecates Object#returning in favor of Object#tap

Signed-off-by: José Valim <jose.valim@gmail.com>