Salut Dominique,

n'oublie pas de préciser si tu attends une action de sa part avant de merger son PR. Sinon il va rester dans le noir…

A+

--FiX

On Mar 13, 2013, at 10:58 AM, Dominique Dumont <notifications@github.com<mailto:notifications@github.com>>
 wrote:


In phobos/source/EditorSettings.js:

> +
> +    showPopup: function(inSender) {
> +             //console.log(inSender.name,    this.parent.f1key);
> +             this.key = inSender.name;
> +             this.$.modalPopup.show();
> +             this.$.inputDecorator3.setContent("john");
> +     },
> +
> +     closeModalPopup: function(inSender) {
> +     //      console.log(this.$.proKey,inSender);
> +             this.$.modalPopup.hide();
> +     },
> +
> +     inputChanged: function(inSender, inEvent) {
> +             var key = this.key;
> +             if(this.key === "F1"){


Hmm. lines 195-241 could be written with something like:

if (/^F\d+/.test(key)) {
locallStorage[key] = inSender.getValue();
}

Note that I haven't tested this suggestion

Hope this helps

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/ares-project/pull/231/files#r3350789>.