my inclination was to test the dropdown, but i think rob encouraged only to
check that a notification was being made and to trust the notification
system was behaving and was tested well enough elsewhere

agree on not spending too much more time/energy on this


On 28 September 2013 09:19, Aaron Thornton <notifications@github.com> wrote:

> In features/step_definitions/user_added_to_group_steps.rb:
>
> > @@ -0,0 +1,12 @@
> > +Given(/^a coordinator adds me to a group I don't already belong to$/) do
> > +  group = FactoryGirl.create :group
> > +  inviter = group.admins.first
> > +  membership = group.add_member! @user, inviter
> > +  Events::UserAddedToGroup.publish!(membership, @user)
> > +end
> > +
> > +Then(/^I should get an added to group notificaiton$/) do
> > +  @user.notifications.joins(:event).
> > +      where('events.kind = ?', 'user_added_to_group').
> > +      order('notifications.id').should exist
> > +end
>
> @s01us <https://github.com/s01us> I would think this should really be
> testing that the notification is visible within the dropdown. The unit
> tests do most of this work. I also think that you shouldn't bother spending
> too much time on this as it is only one piece of the pie which is probably
> going to change soon anyway. Have a chat to @Jon <https://github.com/Jon>about priorities.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/loomio/loomio/pull/1084/files#r6639878>
> .
>