On Fri, Oct 25, 2013 at 01:43:19AM -0700, vadmium wrote:
> > @@ -56,9 +56,14 @@ class Matcher(object):
> >  class StaticStringMatcher(Matcher):
> >  
> >      branch = "master"
> > +    
> > +    def __init__(self, trunk_path):
> > +        if not trunk_path.startswith("/"):
> > +            raise SystemExit("Trunk path does not start with a slash (/)")
> 
> On 25/10/2013, Jelmer Vernooij <notifications@github.com> wrote:
> > SystemExit seems harsh here; why not just ValueError?
> 
> I tend to use SystemExit to report fatal errors to the user in CLI
> programs, because there is no traceback. It’s the same as calling
> sys.exit(). However I’m happy to raise ValueError if you prefer.

It's a programmer error, sure - but it's not fatal enough that the
interpreter should stop running. This kind of error doesn't trigger exit()
elsewhere in python either. For example, list(1) just raises TypeError, too.

Jelmer