finish the update on roles