Can we get Peter Fogg or DB or Julian to wire up the notification mechanism
on the client instead of pushing it on Chris?


On Tue, Aug 6, 2013 at 9:22 AM, Brian Talbot <notifications@github.com>wrote:

> In cms/templates/export.html:
>
> > @@ -6,6 +6,24 @@
> >  <%block name="title">${_("Course Export")}</%block>
> >  <%block name="bodyclass">is-signedin course tools export</%block>
> >
> > +<%block name="jsextra">
> > +  % if err_msg:
> > +  <script type='text/javascript'>
> > +    $(document).ready(function() {
> > +      var defaultTitle = gettext('There has been an error with your export.');
> > +      var msg = "${err_msg}";
> > +      dialog = new CMS.Views.Alert.Confirmation({
> > +          title: defaultTitle,
> > +          message: msg,
> > +          intent: "error",
> > +          closeIcon: false
> > +      });
> > +      dialog.show();
>
> @chrisndodge <https://github.com/chrisndodge>, I'm not sure we're using
> this method of showing alerts elsewhere (our plan on the design side was to
> have CSS-based classes control the visibility and animation of elements
> rather than relying on JQuery's .show()/.hide() methods.
>
> It looks like you may be adding this to make the alert UI accommodate a
> case it was never supposed to - asynchronous error messaging (it was meant
> to be displayed when a page was loaded after a traditional page request).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/589/files#r5603493>
> .
>