Explain where the results go
There is no this pointer in static function calls
Remove the generic attack boards from the bitboard module

The idea is to reduce the register pressure by moving them inside
of Board to give access to the position bitboards directly.
Remove some unnecessary code duplication
Rename the bitboard test data containers