we should have a test for this function