continuing implementing login