Remove general assumption in get_packages()

get_packages() always included 'general' as a default 'service' file.
Remove this assumption and add it explicitly to the primary package
installation call.  This allows get_package() to be used in other places
where 'general' is not desired to be included.

Change-Id: I1eed4386d073d6ae9534aedae32654208c6662e8
Nicira plugin: do not die if NVP gateway IP is missing

Devstack should not die if the IP and prefix len for establishing
a connection to the public network are not provided.
In this case, the public gateway IP address used to configure
Neutron's public network should be used, together with the prefix
length of the public network's CIDR.

This patch also ensures $PUBLIC_BRIDGE is created, even if
Q_USE_DEBUG_COMMAND is disabled. Finally this patch also adds
the teardown operation for restoring the original IP addresses
on the interface used for connectivity to the public network
implemented on the NVP gateway.

Bug #1227750

Change-Id: Ib58738a578c46f2183d503cabfdc6039bfbeb702
baremetal: Allow BM_SECOND_MAC to be unset

Currently DevStack registers the second nic of the baremetal
node even if BM_SECOND_MAC is not set or empty. However
an interface with an empty mac address causes dhcp to fail
(bug 1238595). And such operation will get to return a error
after the bug is resolved. So we should not register the
second nic if BM_SECOND_MAC is not set.

Related-Bug: #1238595
Change-Id: Ib3cc77686b72311403ccacbd70ae9cf43e6eb4c9
remove useless step in cleanup_rpc_backend

It shall not make dir of /var/run/openstack for the cleanup operation.

install_rpc_backend will make the directory, which is covered by another
take care of this.

Change-Id: I2bf1bfb4a6b409cc04f2d7b94dd58627e0134b71
refine rabbit cleanup

Beside it's good to killall -9 epmd,
if killall epmd fails

Change-Id: Ide90ef8ac3339bd70d991666ce0d3550a088670b
add bash8 tool (like pep8, but way hackier)

unlike our python code, we have no automatic style checking for
bash. For the most part, it's not a big deal, but errant whitespace
or incorrect indenting is sometimes annoying to have to -1 people's
patches for. Instead of constantly picking it up in manual review
maybe we can do better.

This is an uber hacky script which could be used to do just that.

   ./tools/bash8.py file1 file2 file3 ...

And it will show issues found with the files at hand. Lightly
tested in the existing devstack tree, it exposes a few issues that
we might want to think about.

This should be python 3 compatible, and includes argparse to provide
a basic '-h' support to explain how the command should be run.

Change-Id: I5009fa5852595c2953a548e430e5e1ce06ae94e0
add a simple run_tests.sh to use bash8

this gives a simple way to run against all the files that we'd
want to check with bash8. Currently clocking in at 300+ errors
(no false pos so far that I see).

Change-Id: Idd83b0bf61029b49bb28ad8b6e6261ecbf927555
Fix false negative, when HEAT_CREATE_TEST_IMAGE is unset

Fix shell variable comparision bug
Closes-Bug: #1239041

Change-Id: Ifbc8545f929eb7bbf9b85df889dfd9fa3a96b7c0
Merge "add bash8 tool (like pep8, but way hackier)"
Merge "add a simple run_tests.sh to use bash8"
Add stack phases to extras.d handling

Add hooks to stack.sh, unstack.sh and clean.sh to call the extras.d
scripts at multiple points in stack.sh.  This allows these scripts to
perform installation and startup tasks at similar times as they would
if integrated into stack.sh.

extras.d/70-tempest.sh is present as an example of the structure
of these scripts.

See extras.d/README.md for more information.

Change-Id: Ic1fe522559b94d204d6c0319a2e3d23684c8d028
Fix fixup_stuff.sh package permissions fix

There are a number of different attempts to fix this issue, specifcally on RHEL6.
None of them actually get it right.
* This does not upgrade an OS installed package because we trust them to not make
  these sorts of permissions mistakes. Also we do not have nor want to figure out the
  right version that the OpenStack projects will require.
* This specfically targets the upstream package versions as we do not know how
  later versions behave.

This should address the following reviews:
* https://review.openstack.org/#/c/50540/
* https://review.openstack.org/#/c/51233/ (1238707)
* https://review.openstack.org/#/c/51651/ (1239747)
* https://review.openstack.org/#/c/51843/
* https://review.openstack.org/#/c/51838/
* https://review.openstack.org/#/c/52148/ (1236941)

Change-Id: I99906451dc25654628187b383e8893cce0e276bf
Merge "Remove general assumption in get_packages()"
Merge "Fix fixup_stuff.sh package permissions fix"
Merge "Add stack phases to extras.d handling"
Use nova.conf for auth_token configs.

Updates lib/nova so that we use the application config file (nova.conf)
instead of the Nova api-paste.ini config file.

Related-Bug #1240753

Change-Id: I393a67f1f005e775928130c9241aa7e25c391ae3
Use cinder.conf for auth_token configs.

Updates lib/cinder so that we use the application config file (cinder.conf)
instead of the Cinder api-paste.ini config file.

Related-Bug #1240753

Change-Id: I6636d33ee522757145ac97fc354324a8b9379700
Don't kill ceilometer prematurally in devstackgate

This change ensure that 'ceilometer' processes are not killed
by stack.sh when USE_SCREEN=False

Fixes bug #1234254

Change-Id: I48dbf18ea0b169cdb5295a709d82c025f6fb8930
Merge "Fix false negative, when HEAT_CREATE_TEST_IMAGE is unset"
Merge "refine rabbit cleanup"