got basic implementation working still a failing test