You might be right.  I tried this out before submissions, and it seemed to
work for my simple test example.  But maybe my simple test example was too
simple.  If you want, you can revert this function to the previous
function, and I can try again to make it compatible with the new directory
inclusion code later.


On Fri, Apr 12, 2013 at 8:38 AM, Bozhidar Batsov
<notifications@github.com>wrote:

> In projectile.el:
>
> >                             (buffer-substring (region-beginning) (region-end))
> > -                         (read-string (projectile-prepend-project-name "Grep for: ") (thing-at-point 'symbol))))
> > -        (root-dir (expand-file-name (projectile-project-root))))
> > -    (require 'grep)
> > -    ;; paths for find-grep should relative and without trailing /
> > -    (let ((grep-find-ignored-directories (append (-map (lambda (dir) (s-chop-suffix "/" (s-replace root-dir "" dir))) (projectile-ignored-directories)) grep-find-ignored-directories))
> > -          (grep-find-ignored-files (append (-map (lambda (file) (s-replace root-dir "" file)) (projectile-ignored-files)) grep-find-ignored-files)))
> > -      (grep-compute-defaults)
> > -      (rgrep search-regexp "* .*" root-dir))))
> > +                         (read-string (projectile-prepend-project-name "Grep for: ") (thing-at-point 'symbol)))))
> > +    (dolist (root-dir roots)
>
> But rgrep doesn't merge results, so you'll creating the result buffer
> over and over again(or I'm missing something). I tried the new code on a
> Rails project and the folders I had in .projectile were no longer ignored
> so I'm pretty sure something is misbehaving here :-)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bbatsov/projectile/pull/88/files#r3771216>
> .
>