I guess its the least bad option:)


On Mon, Dec 2, 2013 at 8:42 AM, Simon Cropp <notifications@github.com>wrote:

> In src/NServiceBus.Core/Pipeline/Contexts/ReceivePhysicalMessageContext.cs:
>
> >          }
> >
> >          public TransportMessage PhysicalMessage
> >          {
> >              get { return Get<TransportMessage>(IncomingPhysicalMessageKey); }
> >          }
> > +        public List<LogicalMessage> LogicalMessages
>
> well we had another bug because we were not doing this in a strong typed
> way. this
> https://github.com/Particular/NServiceBus/blob/develop/src/NServiceBus.Core/Unicast/Behaviors/CallbackInvocationBehavior.cs#L60was returning null since the type was not
> IEnumerable<LogicalMessage>. This highlights my concern about an un-typed
> dictionary.
>
> And it is not misleading since previously it was in the dictionary anyway.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Particular/NServiceBus/pull/1824/files#r8018917>
> .
>