Fix white space bug in argument parser

When parsing arguments that have already been split, white space
should not be treated as a word separator or stripped.

Target: trunk
Require-notes: no
Require-book: no
Acked-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Patch: http://rb.dcache.org/r/6072/
billing: improve the insert queue logic

Revised version of http://rb.dcache.org/r/5841 (discarded)

Currently the way which billing data gets inserted via DataNucleus uses a twin mechanism:  on the one hand, the database API put() calls makePersistent on an open transaction, then asks for conditions to be checked (max inserts or timeout, whichever is reached first), and if so, commits the transaction.  At the same time, a daemon runs which periodically checks to see if those conditions have been met and to commit if so.

This is an unnecessarily complicated logic and can be simplified by making use of the following two features:

1.  java.util.concurrent.BlockingQueue
2.  the built-in batching provided by DataNucleus itself (makePersistentAll).

The database call to put now simply adds the data object to the queue.  A separate thread waits for the queue to be non-empty, then drains it and commits all the objects inside the current critical section.

For added efficiency, the patch implements four separate queues which are mapped to the four separate billing message types/tables; insert is thus specialized via method overloading so that DataNucleus need not have to filter the objects into distinct batched commit statements.

The additional abstraction layer is for flexibility, in case some other façade to the queueing structure is desired.

Several new properties (see below) expose tuning choices.

A separate patch for 2.2 will be posted.

Testing:

Basic functionality tested.

Junit test modified to eliminate meaningless test case; other tests pass.

Stress tests which directly insert to the JDO layer were run with various settings to diagnose stability and performance.

Full testing with billing message processing (using a test cell which produces random billing messages) done on live dcache installation.

Target: master
Request: 2.7
Request: 2.6
Patch: http://rb.dcache.org/r/5992/diff/#index_header
Require-notes: yes
Require-book: yes
Acked-by: Tigran

RELEASE NOTES:
BOOK:

An improved insert strategy for the billing database has been implemented.  The following changes to billing properties should be noted:

billingMaxInsertsBeforeCommit
billing.db.inserts.max-before-commit
billingMaxTimeBeforeCommitInSecs
billing.db.inserts.timeout-before-commit
billing.db.inserts.timeout-before-commit.unit

(one-of?org.dcache.services.billing.db.impl.DirectQueueDelegate)billing.db.inserts.queue-delegate.type=org.dcache.services.billing.db.impl.DirectQueueDelegate

billing.db.inserts.max-queue-size=100000

billing.db.inserts.max-batch-size=1000

(one-of?true|false)billing.db.inserts.drop-messages-at-limit=true

It should be noted that, in conjunction with http://rb.dcache.org/r/5983, which modifies the database triggers, insertion should now perform without message loss (and without running out of memory) under most conditions (3000Hz or less).
namespace: relax HSM URI validation rules

dcache requires hsm type and hsm instance are provided.
Ignore all other rules as it's OPAQUE to us.

Ticket: #7192
Acked-by: Gerd Behrmann
Target: master, 2.7, 2,6
Require-book: no
Require-notes: no
core: fix broken commit 187b136
billing: add commands for recording queue insert data

Adds commands to billing cell to be able to monitor insert queue statistics and to dump threads.

NOTE:  I have decided not to request back-porting to 2.7 or 2.6 for this patch.

TESTING:

[cmssrv153.fnal.gov] (billing) admin > log commit statistics on
on
[cmssrv153.fnal.gov] (billing) admin > log commit statistics off
off

billing log contains:
16 Sep 2013 11:51:32 (billing) [alm-admin-118] insert queue (last 0, current 0, change 0/minute)
16 Sep 2013 11:51:32 (billing) [alm-admin-118] commits (last 0, current 0, change 0/minute)
16 Sep 2013 11:51:32 (billing) [alm-admin-118] dropped (last 0, current 0, change 0/minute)
16 Sep 2013 11:51:32 (billing) [alm-admin-118] total memory 505282560; free memory 482253512

this repeated every minute until turned off.

Target: master
Patch: http://rb.dcache.org/r/5994/
Require-notes: yes
Require-book: yes
Acked-by: Karsten

RELEASE NOTES:
BOOK:

You can now obtain statistics (printed to billing log and pinboard) via the dcache admin command:
display insert statistics <on/off>

Turning this command on logs the following once a minute:

insert queue (last 0, current 0, change 0/minute)
commits (last 0, current 0, change 0/minute)
dropped (last 0, current 0, change 0/minute)
total memory 505282560; free memory 482253512

"insert queue" refers to how many messages actually were put on the queue; "commits" are the number of messages committed to the database; dropped are the number of lost messages. "last" refers to the figures at the last iteration.  For insert queue, this is the actual size of the queue; for commits and dropped, these are cumulative totals.

You can also generate a Java thread dump by issuing the "dump threads" command.
dcache-webadmin: reformat html pages

Wicket mark-up was messy.  All html resources for webadmin have been reformatted for regularity and readability.

(The extra indentation is easier to maintain in my HTML editor.)

Testing: Redeployed and checked webadmin pages.

Target: master
Request: 2.7
Patch: http://rb.dcache.org/r/6077
Require-notes: no
Require-book: no
Acked-by: Tigran
dcache-webadmin: fix page update

This patch addresses several RT tickets stemming from the same problem, one which has already been corrected for the CellServices page (see http://rb.dcache.org/r/5807).

This has to do with the way Wicket PropertyModels were provided for pages which maintain lists which need to be updated through the service layer.  In most of these cases, the list was set in the constructor but was never updated during page/form refresh.  The changes adopted here follow the same general pattern of replacing the field accessed by the model with a getter method which also takes care of calling the service to update the collection in question.

Testing:

Redeployed and checked updating by enabling/disabling pools.

Target: master
Request: 2.7
Patch: http://rb.dcache.org/r/6080
Require-notes: yes
Require-book: no
Bug: http://rt.dcache.org/Ticket/Display.html?id=7929
Bug: http://rt.dcache.org/Ticket/Display.html?id=7964
Bug: http://rt.dcache.org/Ticket/Display.html?id=7983
Acked-by: Gerd
Acked-by: Tigran

RELEASE NOTES:
Fixes an issue with some of the tables in the webadmin service which were not refreshing.  Update correctly occurs now on reload, resubmission of the form through link clicking
Revert "dcache-webadmin: fix page update"

This reverts commit cc7166ad47b6aeada7f2c9ef5ef0a0183d93bb8a.

Need to resolve issue with PoolUsage form.

Will repost when fixed.
Update example layouts

Addresses the problem that the example layout files contains services
and properties that no longer exist or have been deprecated.

Addresses the problem that the head.conf example layout file is a
rather bad example of how to place services in domains. Too many sites
have copied this layout, believing it is a good setup for a head node.
The problem is addressed by removing this layout.

Addresses the problem that our default layout is single, even though
best practice recommendation is to use the host name. The default is
now the host name. This affects sites on upgrade if they relied on the
old default.

Addresses the problem that we ship example files in a configuration
directory. Instead these are now placed in /usr/share/dcache/examples/layouts.

Release notes should probably contain a note reminding RPM users that if
they called their layout file either single, head or pool, that they
should check that RPM didn't rename their layout file.

Target: trunk
Request: 2.7
Require-notes: yes
Require-book: yes
Acked-by: Paul Millar <paul.millar@desy.de>
Patch: http://rb.dcache.org/r/6076/
Make message type final in InfoMessage

The setter was only used during initialization. This patch makes the
field final and sets the value through the constructor. This makes it
simpler to enumerate all possible values in a parser for billing files.

Target: trunk
Require-notes: no
Require-book: no
Acked-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Patch: http://rb.dcache.org/r/6074/
srm: Improve error codes and messages in srmReleaseFiles implementation

Addresses issues in srmReleaseFiles, ensuring that spec compliant return
codes are used, and better error messages are returned to the client.

Addresses issues in which release files in some casses would trigger
IllegalStateTransition exceptions and cause the release file operation
to fail.

The patch refactors some URI handling and request token handling
to reduce the number of times we need to do convert between types.

Target: trunk
Require-notes: yes
Require-book: no
Acked-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Patch: http://rb.dcache.org/r/6086/
srm-client: Add tar packages

Target: trunk
Require-notes: yes
Require-book: no
Acked-by: Dmitry Litvintsev <litvinse@fnal.gov>
Patch: http://rb.dcache.org/r/6087/
srm-client: Fix build failure for RPM package

Target: trunk
Require-notes: no
Require-book: no
nfsv4: use concurrent hash map for mover bookkeeping

Acked-by: Gerd Behrmann
Require-notes: no
Require-book: no
target: master, 2.6
spacemanager: Fix authorization bug in space reservation for non-srm transfers

Target: trunk
Request: 2.6
Request: 2.2
Acked-by: Dmitry Litvintsev <litvinse@fnal.gov>
Patch: http://rb.dcache.org/dashboard/
billing,webdav: Log StringTemplate errors through slf4j

Target: trunk
Require-notes: no
Require-book: no
Acked-by: Paul Millar <paul.millar@desy.de>
Patch: http://rb.dcache.org/r/6096/
cells: Improve routing failure error message

Addresses the problem that "Initial Send" is not a particularly
descriptive error message.

Target: trunk
Require-notes: no
Require-book: no
Acked-by: Paul Millar <paul.millar@desy.de>
Patch: http://rb.dcache.org/r/6098/
hsqldb-plugin: fix transposed varchar settings

The longer varchar (8000) should appear on errormessage but was erroneously given to a different field in a few of the tables.

Target: master
Request: 2.7
Request: 2.6
Require-notes: no
Require-book: no
Acked-by: Gerd
Acked-by: Paul
srmspacemanager: remove code path that has neever been used

    remove code path which has never been used, but was exposed in
    commit f03d1d73fdf79f066a90ac5be2d20ae8ded760f9 by mistake

    Patch: http://rb.dcache.org/r/6100/
    Acked-by: Gerd Behrmann
    Target: trunk
    Require-book: no
    Require-notes: no
dcache-fhs: fix missing chown for httpd directory in debian postinst

Target: master
Request: 2.7
Request: 2.6
Require-book: no
Require-notes: yes
Acked-by: Gerd

RELEASE NOTES
Fixes bug in debian installation preventing writes to the httpd directory and thus blocking creation of webadmin directory.