Yes. That makes sense.

On Dec 10, 2013, at 2:41 PM, "Victor Julien" <notifications@github.com<mailto:notifications@github.com>> wrote:


In src/detect.c:

> @@ -1122,6 +1122,9 @@ int SigMatchSignatures(ThreadVars *th_v, DetectEngineCtx *de_ctx, DetectEngineTh
>          SCReturnInt(0);
>      }
>
> +    /* Load the Packet's flow early, even though it might not be needed */
> +    Flow *pflow = p->flow;


would it make sense to write it like this?
Flow * const pflow = p->flow;
This makes the pointer itself a const, while the data pointed to can still change.

—
Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/707/files#r8244212>.