they were formerly static inner in the old async class. Since users are
inclined to read the "sync" classes, I wanted to extract out  the clutter.
 make sense?


On Tue, Apr 9, 2013 at 11:12 PM, Everett Toews <notifications@github.com>wrote:

> In
> providers/dynect/src/main/java/org/jclouds/dynect/v3/binders/CreateRecordBinder.java:
>
> > +      this.json = checkNotNull(json, "json");
> > +   }
> > +
> > +   @SuppressWarnings("unchecked")
> > +   @Override
> > +   public <R extends HttpRequest> R bindToRequest(R request, Object arg) {
> > +      CreateRecord<?> in = CreateRecord.class.cast(checkNotNull(arg, "record to create"));
> > +      URI path = uriBuilder(request.getEndpoint())
> > +                  .build(ImmutableMap.<String, Object> builder()
> > +                                     .put("type", in.getType())
> > +                                     .put("fqdn", in.getFQDN()).build());
> > +      return (R) request.toBuilder()
> > +                        .endpoint(path)
> > +                        .payload(json.toJson(ImmutableMap.of("rdata", in.getRData(), "ttl", in.getTTL()))).build();
> > +   }
> > +}
>
> This and RecordIdBinder seem really out of place in this PR. Do they
> belong here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/1511/files#r3728161>
> .
>