Disable the new gcc warning for unused-but-set-variable (now included
with -Wall) as it generates more false positives than useful warnings.

Actually, for iRODS code, none of these warnings seemed to be true
positives (and a typical build had 186 of them).

The fix is to just add -Wno-unused-but-set-variable to the gcc command
line.  Hopefully, this will also be OK with older versions of gcc.

In the iRODS coding style, we'd typically call functions and hold the
return code in a variable even if not using that value later.  This
makes the code easier to read (in our opinions) and makes the value
readily available to the debugger when stepping through some
processing.  There are various cases where the caller may 'care' about
the function return code, but some when it does not.

I noticed these warnings when moving from Ubuntu 10.04 to 12.04.  The
new gcc is version 4.6.3.


git-svn-id: svn://irodssvn.ucsd.edu/trunk@5441 ea137bd6-aa86-47b6-b90d-b101d9f19a90
fix compiler warnings

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5442 ea137bd6-aa86-47b6-b90d-b101d9f19a90
fix compiler warnings

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5443 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Add some documentation on the release procedure: two checklists of
tasks and steps that are done.


git-svn-id: svn://irodssvn.ucsd.edu/trunk@5444 ea137bd6-aa86-47b6-b90d-b101d9f19a90
make oprType available to the rule engine

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5445 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Add a acPreProcForExecCmd hook. 
It will be trigerred before executing a binary or script stored in server/bin/cmd through
iexecmd, msiExecCmd or the corresponding APIs.


git-svn-id: svn://irodssvn.ucsd.edu/trunk@5446 ea137bd6-aa86-47b6-b90d-b101d9f19a90
move error message generated from microservices to a rule engine managed error buffer so that they can be obtained using the errormsg microservice

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5447 ea137bd6-aa86-47b6-b90d-b101d9f19a90
add a failmsg microservice which takes in an error code and an error msg and generate an error with that error code and that error message

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5448 ea137bd6-aa86-47b6-b90d-b101d9f19a90
add a failmsg microservice which takes in an error code and an error msg and generate an error with that error code and that error message

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5449 ea137bd6-aa86-47b6-b90d-b101d9f19a90
correct message for r5449: add a parameter containing the command to the pre proc rule for msiExecCmd

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5450 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Remove unused code

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5451 ea137bd6-aa86-47b6-b90d-b101d9f19a90
replace commenting with #ifdefs to keep code backward compatible with the old rule engine.

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5452 ea137bd6-aa86-47b6-b90d-b101d9f19a90
add nre.ruleAdminMS.c

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5453 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Include SHA1 as one of the optional tests noted on the summary line
(forgot to include in the commit a few days ago).


git-svn-id: svn://irodssvn.ucsd.edu/trunk@5454 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Add a "." operator which can be used to create, modify, and access keyValPair_t within the rule language. See testKV.r for examples.

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5455 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Fixed a bug in matchVaultPath() and matchCliVaultPath() that made msiSetChkFilePathPerm("chkNonVaultPathPerm") block registration of files in the user's own vault directory, instead of allowing it as described. Also fixed incorrect comments in the code (zone name is not used in physical paths).


git-svn-id: svn://irodssvn.ucsd.edu/trunk@5456 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Add a log message for the case where an empty regParam is provided to
rsModDataObjMeta and so is being ignored.

This can happen in some situations when 3.1 and 3.2 servers are mixed
due to some changes in how the packing/unpacking functions work.

The case noticed was when a 3.1 IES was being used and a 3.2 non-IES
was being installed.  As a last step in this 'irodssetup' does a iput,
iget, and diff and it was the diff that was failing.  The iput
silently failed too as this call (from agent to agent) failed and so
the size was still 0.  This does not fix that, but at least there
would something in the server log to indicate something unusual.



git-svn-id: svn://irodssvn.ucsd.edu/trunk@5457 ea137bd6-aa86-47b6-b90d-b101d9f19a90
Avoid generating PAM-derived passwords for which the scrambled form
contains a single quote (') as this causes issues on some platforms
(Suse 12 and perhaps others).  

The logic is to just retry (generate a new password) if there is a
single quote in the scrambled form.  It will retry up to 10 times, if
needed (retries should be rare tho).  It will log the retry as a
Notice level message and if they all fail, as an Error.

This was provided in large part by the E-iRODS folks (Jason C),
thanks!


git-svn-id: svn://irodssvn.ucsd.edu/trunk@5458 ea137bd6-aa86-47b6-b90d-b101d9f19a90
fix memory leaks in the rule engine code

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5459 ea137bd6-aa86-47b6-b90d-b101d9f19a90
fix a compiler error

git-svn-id: svn://irodssvn.ucsd.edu/trunk@5460 ea137bd6-aa86-47b6-b90d-b101d9f19a90