I think they make sense here, there's not really any other alternative
parameters or whatever you'd have.


On Tue, Oct 29, 2013 at 11:00 AM, Donald Stufft <notifications@github.com>wrote:

> In cryptography/hazmat/primitives/padding.py:
>
> > +        super(PKCS7, self).__init__()
> > +        if not (0 <= block_size < 256):
> > +            raise ValueError("block_size must be in range(0, 256)")
> > +
> > +        if block_size % 8 != 0:
> > +            raise ValueError("block_size must be a multiple of 8")
> > +
> > +        self.block_size = block_size
> > +
> > +    def padder(self):
> > +        return _PaddingContext(self.block_size)
> > +
> > +    def unpadder(self):
> > +        return _UnpaddingContext(self.block_size)
> > +
> > +    def pad(self, data):
>
> Do we think these helper functions should be left out similarly to
> encrypt() and decrypt() ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/192/files#r7288249>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084