refactored to rolescreator