Nah, leave it, it is more readable. We should have a recommendation for
this kind of thing in our 'coding standards' doc that doesn't exist yet. I
would hope it says to refactor code for readability, so this is a good
change. but, for review, I would have one commit that's the change and
another that's the refactor. Refactor, to me, has no other meaning than
'non-functional change that improves the code base'. Being able to see, in
the review, that you intended no functional change guides the reviewer to
confirm that, rather than squint for a subtle change.


On Fri, Sep 6, 2013 at 2:31 AM, Benjamin Bastian
<notifications@github.com>wrote:

> In src/fabric_doc_update.erl:
>
> >      Timeout = fabric_util:request_timeout(),
> >      try rexi_utils:recv(Workers, #shard.ref, fun handle_message/3, Acc0, infinity, Timeout) of
> >      {ok, {Health, Results}} when Health =:= ok; Health =:= accepted ->
> > -        {Health, [R || R <- couch_util:reorder_results(AllDocs, Results), R =/= noreply]};
> > +        Reordered = couch_util:reorder_results(DocRefs, Results),
> > +        {Health, [R || R <- Reordered, R =/= noreply]};
>
> Yeah. Should I change it back to one line?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cloudant/fabric/pull/105/files#r6199431>
> .
>