added logic tests