Should we exit or log an error skip the current metric?

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, November 19, 2013 9:39 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Subject: Re: [naarad] removed access attribute; added/enforced hostname attribute (#13)


In bin/naarad:

>          try:
> +          if config_obj.has_option(section, 'hostname'):
> +            hostname = config_obj.get(section,'hostname')
> +            if not is_valid_hostname(hostname):
> +              logger.error('The hostname of %s is invalid in section %s'  % (hostname, section) )


Sounds good. Then lets use logger.critical or sys.exit

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/13/files#r7765083>.