-> Point 2.b of HQ review
2.b tab processing (switch default) is a path security problem for unknown tab names
was fixed entering a print_error. I fell the print_error is a good solution because $currenttab is assigned by code so... the default switch should never be verified. If verified it is a real serious problem.
-> allowed a survey in the fromt page. An error is still there but I can not understand why it occurs. The issue is: the front page user (non authenticated user) has no submit permission. Why? guest has it. As soon as I get the reason of this issue, I will fix it.
-> added managesubmissions permission. Everyone has this permission but guest. I am forced to do this because the non authenticated user submitting a survey, is REALLY anonymous. This is why I can not allow him/her to edit his/her submission.
-> reports are now very tiny classes
-> fixed the percentage frequency that now sums to 1 in the frequency report
-> changed upgrade_plugin_savepoint syntax (was it wrong before? If so, why if worked up to today? Does Moodle HQ changed it?)
-> revisited view_manage.class.php->prevent_direct_user_input
-> revisited view_userpage.class.php->prevent_direct_user_input