Not planned for pulling into this pull request.

If I understand it correctly Michael does not wish to use non standard
classes for http statuses.  That's very sensible and I should not have
pulled it in.  I prefer using the numeric status code, and will adjust
calls throughout to reflect this.

  I recall doing this as part of changes to the security check (about the
only place it matters) but that would need some cherry picking out.

I think we should find a formula for reviews such as

(i) - information or discussion request - I have not decided
      Yet and am just asking
-1: this must be changed before it goes any further
0: I want to agree a worded issue so that while I think this should be
changed its not severe enough to merit holdin up the patch
+1: go ahead

Any thoughts?


Paul Brian
07540 456 115
paul@mikadosoftware.com
Guiding you towards Continuous Delivery of software and business value.

On 15 Apr 2013, at 17:45, Philip Schatz <notifications@github.com> wrote:

In rhaptos2/repo/err.py:

> @@ -17,3 +19,14 @@ class Rhaptos2Error(Exception):
>  class Rhaptos2SecurityError(Exception):
>      pass
>
> +### To Be used for generioc raising of errors - expect to replace
> +### most calls with more specific error
> +
> +
> +class Rhaptos2HTTPStatusError(HTTPException):
> +    pass
> +
> +
> +class Rhaptos2AccessNotAllowedError(HTTPException):

Will this be fixed in the pull req?

—
Reply to this email directly or view it on
GitHub<https://github.com/Connexions/rhaptos2.repo/pull/111/files#r3797142>
.

-- 


www.mikadosoftware.com

See your software improve with every change.