It might be easier to create a review request for this. See:

https://sites.google.com/a/aristanetworks.com/onestop/eos-extensibility/how-to-get-an-extension-reviewed#TOC-How-to-submit-an-extension-for-code-review

on how to easily do that.


Thanks,
Andrei


On Thu, Aug 8, 2013 at 6:14 AM, Andre Pech <notifications@github.com> wrote:

> In neutron/plugins/ml2/drivers/mech_arista/config.py:
>
> > +experience as well control over the Arista Hardware.
> > +"""
> > +
> > +ARISTA_DRIVER_OPTS = [
> > +    cfg.StrOpt('eapi_user',
> > +               default=None,
> > +               help=_('Username for Arista EOS')),
> > +    cfg.StrOpt('eapi_pass',
> > +               default=None,
> > +               secret=True,  # do not expose value in the logs
> > +               help=_('Password for Arista EOS')),
> > +    cfg.StrOpt('eapi_host',
> > +               default=None,
> > +               help=_('Arista EOS host IP')),
> > +    cfg.BoolOpt('use_fqdn',
> > +                default=False,
>
> With an option named "use_fqdn", the value has to reflect whether you're
> actually returning the fully qualified domain name. A value of False means
> that we would not be returning the fqdn.
>
> If you want the default to be False, then I think the option name needs to
> be renamed to "truncate_hostname" or "use_shortname".
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/aristanetworks/neutron/pull/2/files#r5650879>
> .
>