Remove trivial cases of unused variables

Removes trivial cases of unused variables from V3 API version of
servers.py. This was applied to the V2 API but not the V3 API
in commit 9f7eaca80d259201844f097fec24d1e9fe9fb5e3.

Change-Id: I42c1eb73a502afb61bf9c2dd81b79266e0966b5f
Update mailmap

Change-Id: I7cc1c069aefca3f61328fa92d7366b5b755febaf
Remove duplicate variable _host_state

* The variable _host_state is initialized twice in __init__() method of libvirt driver.
This patch removes the second occurrence.

Fixes bug #1214431

Change-Id: I13f175abcbce7752afb0d8c69ee209928afa1eb3
Fix remove_fixed_ip test with CastAsCall

If you enable CastAsCall, a bunch of issues with the remove_fixed_ip
API sample integration test crops up.

Firstly, the sample network is getting created with 'fake-mini' from
CONF.host as the network host rather than the host UUID generated for
the network service in start_service(). This results in
allocate_fixed_ip() attempting to invoke an RPC on a non-existant host.

Secondly, the test is attempting to remove a fixed IP which was never
allocated. Use the add_fixed_ip() test to allocate a fixed IP and then
remove that one, which is 10.0.0.3 rather than 10.0.0.2 which is the
IP reserved for VPN.

Lastly, disable the instance DNS manager because it seems this isn't
compatible with multinic. I was getting FloatingIpDNSExists raised.

blueprint: oslo-messaging
Related-Bug: #1213251
Change-Id: I9854863bbec8834c638c55832411f63da570f82d
Stub out attach_volume() in test_api_samples

If you enable CastToCall, the attach_volume_to_server() test fails when
it attempts to connect to cinder (i.e. initialize_connection()).

Best thing is to just stub out the attach_volume() call.

blueprint: oslo-messaging
Change-Id: I75f4e3fd1ecd0635867c167872a8eb7606cf295e
Enable CastAsCall for test_api_samples

Like the EC2 tests, the API sample tests are pretty much full-on
integration tests.

However, unlike the EC2 tests, the API tests currently don't use
CastAsCall. Without CastAsCall enabled, it seems that a bunch of issues
are masked simply because the test exits before some RPC casts ever get
executed.

The previous commits fix the cases where CastAsCall causes a failure.
This commit just enables it. Hopefully, it will ensure issues don't get
masked in future.

blueprint: oslo-messaging
Change-Id: Ib01797cec76c7cb3298808636e1b27fec4175594
Stub out more net API methods floating IP DNS test

Otherwise e.g. create_public_dns_domain() fails if we time out call()s
in the fake RPC driver when there are no consumers for a topic.

blueprint: oslo-messaging
Change-Id: I44455fa23c4b0e4026414d74379361de0576cbeb
Merge "Update mailmap"
Merge "Remove duplicate variable _host_state"
Merge "Remove trivial cases of unused variables"
Merge "Fix remove_fixed_ip test with CastAsCall"
Merge "Stub out attach_volume() in test_api_samples"
Merge "Enable CastAsCall for test_api_samples"
Merge "Stub out more net API methods floating IP DNS test"