Update to rra-c-util 4.9

* Fix clang warning in snprintf replacement
* Add another ignore pattern to the valgrind suppressions

Change-Id: Ie5e2e4c452410ca04777849f5957aba45c93b29f
Reviewed-on: https://gerrit.stanford.edu/1219
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Stop substituting Perl module versions in configure

The Perl modules now have static version numbers, which are updated
using the --update option of the tests/perl/module-version.t script
(coming in the next commit).  Remove the configure machinery.

Also make the Perl module rebuild depend on Net::Remctl::Backend.

The version numbers of the Net::Remctl and Net::Remctl::Backend Perl
modules now match the versions of the remctl package, but with at
least two digits for the minor version so that, for example, 3.9
(which becomes 3.09) and 3.10 will sort properly as numbers.  This
means that, from Perl's perspective, the version numbers have gone
backwards in this release relative to earlier 3.0 releases.  This is a
one-time adjustment to a more reliable versioning scheme.

Change-Id: I0a0811f13ca35428cbd97ad9d9fc34f79bb7c56b
Reviewed-on: https://gerrit.stanford.edu/1220
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Add test and update script for Perl module versions

Add a test script that will check that all Perl module versions
match the overall package version, and that supports an --update
option to fix the versions.

Change-Id: I659f557817d95a2356134cc32b155ac9f48b8a6b
Reviewed-on: https://gerrit.stanford.edu/1221
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Release 3.5

Change-Id: I723565253968064782b2cc4e918872eb7f41d6c9
Reviewed-on: https://gerrit.stanford.edu/1222
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Add tests/perl/module-version-t to the distribution

Change-Id: Iae94ce36bd2925541331a820482c9f158203e184
Reviewed-on: https://gerrit.stanford.edu/1223
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Move the protocol license statement to the generated document

If this is submitted as an RFC, I'll have to do something else, but
in the meantime this makes the license situation clearer and avoids
having some exceptions for build-license.

Change-Id: Ifbda742d29bbde0e27bc7028d3130ee9252cb779
Reviewed-on: https://gerrit.stanford.edu/1224
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Add explicit licenses for some long test data files

These probably aren't copyrightable, but it simplifies the build-license
handling.

Change-Id: If479888026b520123d42fd6cec8e209b946b3c51
Reviewed-on: https://gerrit.stanford.edu/1225
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Refresh LICENSE for release 3.5

Change-Id: Ia8658e0b1074df4e39fd99afc77a0504c6fd6782
Reviewed-on: https://gerrit.stanford.edu/1226
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Include php/remctl.ini in the distribution

Change-Id: I3d86fd141d24faf35614f080dd713bc43bad595f
Reviewed-on: https://gerrit.stanford.edu/1227
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Add AC_SYS_LARGEFILE to configure.ac

This probably doesn't matter for what remctl and remctld do currently,
but it might with file upload, and there's no reason not to use the
LFS API by preference anyway.

Change-Id: Ideddb4edcae9f30a82dead11cafedd3ee5a17dbc
Reviewed-on: https://gerrit.stanford.edu/1228
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Properly link all the test suite programs

Now that we potentially probe for Kerberos libraries, we may use
the native Kerberos method to obtain tickets.  In that case, we
have to link all the test programs that may obtain Kerberos tickets
with the Kerberos libraries directly.  Add the required libraries
and linker flags.

Change-Id: If5b7a93361a8690f1494a7516a00a5c7fe4ac88e
Reviewed-on: https://gerrit.stanford.edu/1229
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Pass LDFLAGS through to the Perl module build

This is the correct way to get hardening flags enabled in Debian,
plus it seems like a good idea in general.

Change-Id: I7c324b76b46c75fcff74114d30518ab16d8683ef
Reviewed-on: https://gerrit.stanford.edu/1230
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
include utils/macros.h in client/open.c

client.c uses the UNUSED macro. Include the header file that defines
this macro.

Change-Id: I7939268fc4652d78ae629a91265bc1e11e0dc827
Reviewed-on: https://gerrit.stanford.edu/1254
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Minor tabification fix in Makefile.am

Change-Id: Id61ea7d3025f677fe66b7d85d4ef2fd85a2d3c69
Reviewed-on: https://gerrit.stanford.edu/1255
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Check fwrite status in the client

This is mostly to silence clang builds, but there are some edge
cases where this will report an error that otherwise wouldn't have
been reported.

Change-Id: I85cce8d52cc8569a49c4fdb2f1cf8cfa6398b1a3
Reviewed-on: https://gerrit.stanford.edu/1256
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Restart the client nonblocking connect wait on EINTR

If the client specifies a timeout, restart the wait for a nonblocking
connect when interrupted by a signal.  This can mean that a connect
can take longer than the timeout if interrupted; hopefully both
timeouts and catching signals are rare enough that this won't pose a
serious issue.

Change-Id: Ice391360acc66602d31f2d1bd2fe9296b6d7ff45
Reviewed-on: https://gerrit.stanford.edu/1257
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Add NEWS entry for the UNUSED compilation bug fix

Change-Id: I6e8a62a3df0902a6785cb294eb5e9c499bf4cb7c
Reviewed-on: https://gerrit.stanford.edu/1258
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Include more portability glue for Mac OS X Heimdal

If Kerberos support is detected, we build the native Kerberos
version of the kerberos.c TAP add-on, which requires a few more
function probes than we were doing.  Reported by Jacob Welsh.

Change-Id: Ic41d540b3d92e2bf4e4e943e62d0b02e19fbe3bd
Reviewed-on: https://gerrit.stanford.edu/1259
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Fix PCRE detection (or lack thereof) on Mac OS X

Fix problems with PCRE detection on platforms that have the library
but not pcre-config or the pcre.h header file, such as Mac OS X.

Change-Id: If0ec8c42a5e3ae39aafdedd54bfecdbd600bf7b4
Reviewed-on: https://gerrit.stanford.edu/1260
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>
Fix Net::Remctl::Backend help formatting with long syntax

The help output from Net::Remctl::Backend now checks for commands
whose syntax is excessively long and does not let them influence the
formatting of the summary.  This keeps commands with a long syntax
from forcing all the summary output into a skinny column against the
right margin and allows proper help output for commands with a syntax
longer than 80 columns.

Change-Id: Ie498048961e4ceaa507b17c7ceec319cd9ea377d
Reviewed-on: https://gerrit.stanford.edu/1261
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>