SimplePushSpecPage: isEmpty() is undefined for the type String in Java 5

Change-Id: I8ca1437882864fe344deed0602ef13162ec98bfe
IndexDiff Cache: fix cancellation issue

It was not possible to cancel the "Re-indexing repository" job while
this job was waiting for the workspace lock.

Bug: 373077
Change-Id: Iade4dc9fa1445536e7a2a78ef0f22e82e2a331e2
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Merge "IndexDiff Cache: fix cancellation issue"
Close Synchronize View after each synchronize test

We frequently observe failing synchronize tests timing out when looking
for some widget, typically re-running the failed test separately without
repeating all the tests in the test suite succeeds. Closing the
synchronize view between tests seems to reduce the chance of
interferences between synchronize tests when they are all run in one
test run.

Change-Id: I107b6d06b307d238195f1a6f429bca7fd075a010
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Fix diff icons and left/right sides in History View compare

When comparing two commits via "Compare with Each Other" in History
View, there were two problems:

1. For CHANGE cases, the commit ID label and the actual content of the
   sides did not match. This is fixed by always showing compareRev on
   the left, consistent with setLeftLabel and setRightLabel earlier in
   the code.

2. For ADDITION/DELETION cases, the icon shown in the tree was reversed.
   For an addition (file doesn't exist in base/right, exists in
   compare/left), a [-] was shown (weird). By ORing it with
   Differencer.RIGHT, we get a nice left to right arrow with a +/- in it
   (which is then correct).

Bug: 350623
Change-Id: I11bfbdfd48dd3d40689f1c4db030a207d570410b
Signed-off-by: Robin Stocker <robin@nibor.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Merge "Close Synchronize View after each synchronize test"
Add setting for streamFileThreshold in the UI.

This was the only missing setting from WindowCacheConfig.

Change-Id: I73e72d8b35e448f01aa226b9eb5c157220a4cda5
Add a menu item for unstaging changes

Most of the code was in place, we just needed the menu and an icon

Bug: 309362
Change-Id: I7de57e20fce352ef68543b0089e8db8673800cd1
[sync] Fix refreshing Git Commits model after repository change

Commit f52917721af7c7dfce44cc655fb3586a811793fb broke refresh Git
Commits model after repository change event capability by caching result
of first children computation inside repository and root model object.

This patch preserves proper disposing of resources and fixes done in
above mentioned change for refresh of Git Commit model.

Bug: 345286
Change-Id: I7be92924973f67e21ce811aa17ee2d9afcc33118
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Shift the Git perspective icon and enhance the letters

Matthias Sohn provided the enhanced letters

Bug: 359662
Change-Id: I66029a8b3413518df4471e2350dc7ab908f99aff
Merge "Shift the Git perspective icon and enhance the letters"
Make order predictable when pulling multiple projects

https://git.eclipse.org/r/#/c/4937/ tried to make the order predictable,
but HashMap was used again in two locations. 

Change-Id: I5bef6478eea34aff13af570f0932e2fc842fd8cb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Merge "Add a menu item for unstaging changes"
Create Patch on staged file broken

The patch wizard should open if the selection contains a modified,
untracked or missing file. Otherwise, the "No changes" dialog should
be shown. The fix utilizes IndexDiffCache to achieve that.

Bug: 376187
Change-Id: I7dd7358dfc1b2a05fcbd6dec24bc819d96d31c4f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Postpone handling of ref changes in GitDocument to the event loop

RefChange events may come from any thread, so do not assume we may
handle them right here.

Bug: 344402
Change-Id: I04b731abf0126087622292daa6f39600ade8f945
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
[repoView] Improve dialog message for "Reset..." action

When resetting to the current branch it doesn't make sense to mention
the branch name as targetRef again. Also show the commit the targetRef
is referring to.

Change-Id: I4ee10652f7509c4bb42305f4f45a110291285046
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
[historyView] Allow to rename branches

It is often helpful to be able to rename a branch (for example, you
happened to commit into the "master" branch and want to rename it to
reflect your feature).

Without being able to do this on the History View, this is rather
cumbersome.

[MS]
Pre-populate the new name with the old name and select it fully. If
the user wants to just slightly alter the old name instead of replacing
it with a completely different name this requires less keystrokes for
the same result.

Change-Id: Ib059c8b00d9d062032dfa87400147ea80d364411
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Remove unnecessary null check

Bug 341076
Change-Id: I20b6dade3bd692086db5992bf5afb33bb2152255
Signed-off-by: Dani Megert <Daniel_Megert@ch.ibm.com>
Reuse BranchRenameDialog in Repositories View

Change-Id: Idf3170326c86a8d35a38a9ce90b9f46fd6047e7a
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Remember values in Create Patch wizard's options page

Bug 377390
Change-Id: If370b321bbc34877087364bf291af8b290f1f0fa
Signed-off-by: Dani Megert <Daniel_Megert@ch.ibm.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>