I'm pretty sure I made a complete mess with rebase and squash.
I'm new to git.


commit: bb344d3 - ENH: Optimize array creation by avoiding
errors<https://github.com/m-d-w/numpy/commit/bb344d397d42414e87e042f0ec7fc965d6f4cf7c>

https://github.com/m-d-w/numpy/commit/bb344d397d42414e87e042f0ec7fc965d6f4cf7c

and

commit: acd8675<https://github.com/m-d-w/numpy/commit/acd8675797a1c5a4f881e0cfd1706ab87716c6bd>
- TST: Add basic tests for np.array

https://github.com/m-d-w/numpy/commit/4467491c981231fe54004209c16a7ca0be220d0e



On Thu, Jun 6, 2013 at 9:22 AM, seberg <notifications@github.com> wrote:

> In numpy/core/tests/test_api.py:
>
> > @@ -96,6 +238,8 @@ def test_array_astype():
> >      b = a.astype('S')
> >      assert_equal(a, b)
> >      assert_equal(b.dtype, np.dtype('S100'))
> > +
> > +    from numpy.compat import sixu
>
> Can you move this back to the module level import, I don't understand why
> it should go here? Further up +np.nan is OK, but should have spaces
> around the +. I always need a bit to figure out what ocnt means, but I
> don't mind much. There is a lot to add (like the behaviour when casting),
> but this is at least *something* :). Further style nitpick: no spaces
> here [ nested ], there was also in the C code on more time no spaces
> around the ==. Anyway these are all just minor style nitpicks, over all I
> think this is good modulo someone elses opinion of the general approach.
>
> Before this can be merged it has to be Squeezed. Best make two commits one
> for the tests such with a message along the lines "TST: Add basic tests for
> np.array" and possibly more explanation in the next lines and for the real
> changes something like "ENH: Optimize array creation by avoiding errors" or
> whatever message you feel good (with more explanation in the next lines
> again). But you can wait with that until others had time to look at it and
> comment. You can do this with interactive rebase:
> https://help.github.com/articles/interactive-rebase
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/3396/files#r4566975>
> .
>