bug #9327 [2.2][Form] Changed FormTypeCsrfExtension to use the form's name as default intention (bschussek)

This PR was merged into the 2.2 branch.

Discussion
----------

[2.2][Form] Changed FormTypeCsrfExtension to use the form's name as default intention

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Before, every form used the same "intention"/"csrf_token_id" value by default, namely "unknown". This PR fixes the default value to the form's name, which is at least different for forms with (a) explicit names and (b) different types, where the implicit name equals the type's name.

Commits
-------

b07c618 [Form] Changed FormTypeCsrfExtension to use the form's name as default intention
Fix docblock typo
minor #9312 [Security] Fix docblock typo (adrienbrault)

This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9312).

Discussion
----------

[Security] Fix docblock typo

Commits
-------

bff65b2 [Security] Fix docblock typo
[Intl] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty
[Intl] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty
[DoctrineBridge] Added type check to prevent calling clear() on arrays
bug #9338 [DoctrineBridge] Added type check to prevent calling clear() on arrays (bschussek)

This PR was merged into the 2.2 branch.

Discussion
----------

[DoctrineBridge] Added type check to prevent calling clear() on arrays

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

4ff59d7 [DoctrineBridge] Added type check to prevent calling clear() on arrays
bug #9333 [2.2][Form] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty (bschussek)

This PR was merged into the 2.2 branch.

Discussion
----------

[2.2][Form] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

ping @stof

follow-up PR to #9327

Commits
-------

219e44d [Intl] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty
bug #9334 [2.3][Form] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty (bschussek)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][Form] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty

#9333 merged into 2.3.

Commits
-------

baa2356 [Intl] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty
Merge branch '2.2' into 2.3

* 2.2:
  [DoctrineBridge] Added type check to prevent calling clear() on arrays
  [Intl] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty
  Fix docblock typo

Conflicts:
	src/Symfony/Component/Form/Extension/Csrf/Type/FormTypeCsrfExtension.php
[Process] Fix #9343 : revert file handle usage on Windows platform
Clean up of WebProfiler Controller classes:

Added missing "@throws" PHPdoc comments in controllers
Updated deprecated reference to Symfony\Component\HttpKernel\Debug\ExceptionHandler to use Symfony\Component\Debug\ExceptionHandler instead
minor #9359 Clean up of WebProfiler Controller classes (caponica)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #9359).

Discussion
----------

Clean up of WebProfiler Controller classes

 - Added missing "@throws" PHPdoc comments in controllers
 - Updated deprecated reference to Symfony\Component\HttpKernel\Debug\ExceptionHandler to use Symfony\Component\Debug\ExceptionHandler instead

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no

Commits
-------

592b831 Clean up of WebProfiler Controller classes:
Fixed English usage for existing users.
git push #9372 Fixed English usage for existing users. (mgenereu)

This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9372).

Discussion
----------

Fixed English usage for existing users.

Commits
-------

b674e44 Fixed English usage for existing users.
bug #9354 [2.2][Process] Fix #9343 : revert file handle usage on Windows platform (romainneutron)

This PR was merged into the 2.2 branch.

Discussion
----------

[2.2][Process] Fix #9343 : revert file handle usage on Windows platform

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9343
| License       | MIT

Hello,

I propose to revert the use of file handles only for `STDOUT` on Windows platform (see implementation in 2.2.6 [here](https://github.com/symfony/symfony/blob/4059720232e8c4acce6ca31627b87b904cf1aa77/src/Symfony/Component/Process/Process.php#L231-L242)).

When I decoupled pipes management from `Process` in #8924, I used file handles for both `STDOUT` and `STDERR`. This was an error as it introduced random failure in reading the handles (reported as [PHP#65650](https://bugs.php.net/bug.php?id=65650)).

Reverting to the previous implementation solves the issue. My apologies for the issues it introduced.

Versions that have been affected by the bug are 2.2.7, 2.2.8, 2.2.9, 2.3.4, 2.3.5 and 2.3.6.

Side note : I thought about testing the file handles implementation on *nix, but it fails most of the time where as Windows is okay. Unit testing on windows is okay (AbstractProcessTest::testProcessPipes tests it), but I don't provide a travis compatible test.

Commits
-------

e9dd408 [Process] Fix #9343 : revert file handle usage on Windows platform
Merge branch '2.2' into 2.3

* 2.2:
  Fixed English usage for existing users.
  [Process] Fix #9343 : revert file handle usage on Windows platform