...oh yeah duh. That'd work, but best to make that explicit I think, just
to avoid anyone double-taking over it in the future.


On Mon, Apr 15, 2013 at 9:34 PM, alierak <notifications@github.com> wrote:

> In cgi-bin/LJ/Userpic.pm:
>
> > @@ -1060,7 +1060,9 @@ sub set_keywords {
> >      } else {
> >          @keywords = split(',', $_[0]);
> >      }
> > -    @keywords = grep { !/^pic\#\d+$/ } grep { s/^\s+//; s/\s+$//; $_; } @keywords;
> > +
> > +    map { s/^\s+//; s/\s+$//; } @keywords;
>
> It's building a new list and then throwing it away. But s/// is also
> modifying the elements of the original list.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dreamwidth/dw-free/pull/345/files#r3793345>
> .
>