I still need some more time to investigate if there will be any
consequences to updating the AWS SDK gem. I aim to get this done and pushed
well before the weekend though.


On Tue, Nov 26, 2013 at 11:01 PM, David Kelley <david.james.kelley@gmail.com
> wrote:

> I have just made a commit which removes that override on the AWS::SNS
> class. I have re-worked the tests so that it publishes to a totally locked
> down IAM resource with only the Publish action enabled. Hopefully I got
> this in time for a production push!
>
>
> On Tue, Nov 26, 2013 at 6:35 PM, Corey Donohoe <notifications@github.com>wrote:
>
>> In lib/services/amazon_sns.rb:
>>
>> >    end
>> >
>> > -  def aws_config
>> > -    {:access_key_id=>data['aws_key'], :secret_access_key=>data['aws_secret']}
>> > +  # Return a new AWS SNS Object
>> > +  def aws_sns
>> > +    @aws_sns || AWS::SNS
>>
>> If you can get these defaults done sometime today I should have time to
>> get it out in production and test it. If not we can probably get it out
>> into production sometime next week.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/github/github-services/pull/741/files#r7934272>
>> .
>>
>
>