Sure, as I said, I don't know if you can selectively merge and just take
the Oracle Update.  The Foreman thing is more for me, but I'm not savvy
enough with this git stuff yet to know if I should have reverted back to
your original to do the OracleLinux stuff.

I like the foreman thing because then the puppet module picks up the
Foreman env and puppet master with out much effort.  I suppose I could have
changed the template...there's always 1000 ways to skin a cat.


--
Sean M. Alderman
Senior Engineer, UDit Systems Integration and Engineering
University of Dayton
300 College Park
Dayton, Ohio 45469-1530
(937) 229-5088
salderman1@udayton.edu


On Mon, Aug 5, 2013 at 5:14 PM, Alessandro Franceschi <
notifications@github.com> wrote:

> In manifests/params.pp:
>
> > @@ -21,11 +21,19 @@
> >    }
> >
> >    $mode = 'client'
> > -  $server = $::domain ? {
> > -    ''      => 'puppet',
> > -    default => "puppet.$::domain",
> > +  if $::puppetmaster {
>
> Uhm I don't like the idea of placing foreman-only variables inside the
> module
> but here they seem harmless and add some value, for foreman users...
> have to verify it anyway... when I have time.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/example42/puppet-puppet/pull/58/files#r5590399>
> .
>