Clean up defer_recovery() functions

Signed-off-by: David Zafman <david.zafman@inktank.com>
PG,OSD: mark info as backfilling in _remove_pg()

Signed-off-by: Samuel Just <sam.just@inktank.com>
OSD::clear_temp should clear snap mapper entries as well

Signed-off-by: Samuel Just <sam.just@inktank.com>
OSD: removal collections will be removed inline and not queued

Signed-off-by: Samuel Just <sam.just@inktank.com>
WorkQueue: Allow WorkQueueVal to be specified with 1 type

Signed-off-by: Samuel Just <sam.just@inktank.com>
OSD,PG: lock_with_map_lock_held() is the same as lock()

Signed-off-by: Samuel Just <sam.just@inktank.com>
PG: reassert_lock_with_map_lock_held() is dead

Signed-off-by: Samuel Just <sam.just@inktank.com>
PG: rename must_delay_request to op_must_wait_for_map, make static

Signed-off-by: Samuel Just <sam.just@inktank.com>
mds: fix fd leak

Signed-off-by: Sage Weil <sage@inktank.com>
mon: fix Formatter leak

Signed-off-by: Sage Weil <sage@inktank.com>
os/Filestore: fix fd leak in error path

Signed-off-by: Sage Weil <sage@inktank.com>
rados: fix buffer leak

Signed-off-by: Sage Weil <sage@inktank.com>
rados: fix fd leak

Signed-off-by: Sage Weil <sage@inktank.com>
radosgw-admin: fix fd leak in read_input()

Signed-off-by: Sage Weil <sage@inktank.com>
rgw: fix various uninit class fields

Signed-off-by: Sage Weil <sage@inktank.com>
ceph-filestore-dump: fix uninit fields in ctor

Signed-off-by: Sage Weil <sage@inktank.com>
librbd: fix possible use-after-free

(of the pointer)

CID 966634 (#1 of 1): Use after free (USE_AFTER_FREE)
2. use_after_free: Using freed pointer "ictx".

Signed-off-by: Sage Weil <sage@inktank.com>
rbd: fix buffer leak in do_import

CID 1019580 (#2 of 2): Resource leak (RESOURCE_LEAK)
10. leaked_storage: Variable "p" going out of scope leaks the storage it points to.

Signed-off-by: Sage Weil <sage@inktank.com>
osd: init test_ops_hook

CID 1019628 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member "test_ops_hook" is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Sage Weil <sage@inktank.com>
osd: initialize OSDService::next_notif_id

CID 1019627 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member "next_notif_id" is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Sage Weil <sage@inktank.com>