Oh, yeah definitely. Never been added as a repo collaborator before, will
do going forward.


On Mon, Dec 9, 2013 at 11:18 PM, Mike Perham <notifications@github.com>wrote:

> In lib/sidekiq/launcher.rb:
>
> >        watchdog('Launcher#stop') do
> >          @done = true
> >          Sidekiq::Fetcher.done!
> >          fetcher.async.terminate if fetcher.alive?
> >          poller.async.terminate if poller.alive?
> >
> > -        manager.async.stop(:shutdown => true, :timeout => @options[:timeout])
> > +        opts = force_shutdown_after_timeout ? {:shutdown => true, :timeout => @options[:timeout]} : {}
> > +        manager.async.stop(opts)
> >          manager.wait(:shutdown)
>
> No problem, in the future can you use a branch in the main sidekiq repo so
> I can work on the branch too before merging?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mperham/sidekiq/pull/1387/files#r8221983>
> .
>