still working on collections logic