+1
On Jul 27, 2013 11:20 PM, "abenari" <notifications@github.com> wrote:
>
> In app/models/content/repository.rb:
>
> > @@ -38,5 +47,12 @@ def update_cache
> >        nil
> >      end
> >
> > +    def full_path
> > +      pulp_url = URI.parse(Setting.pulp_url)
> > +      scheme = (unprotected ? 'http' : 'https')
> > +      port = (pulp_url.port == "443" || pulp_url.port == "80" ? "" :
":#{pulp_url.port}" )
>
> I don't think so, in case of port 443 or 80 this code drops the port.
> My suggestion however is to drop the port entirely at this point, because
guessing the repository port from the api port is not a good practice to
start with. To properly support this feature, we should get the full url of
the repository from pulp server.
>
> —
> Reply to this email directly or view it on GitHub.