It's there only to unify the error handling for the two error conditions for logging in the defer.

We could pull it out into a separate method if you'd prefer.

Bernerd

> On Oct 11, 2013, at 16:40, Alexander Simmerl <notifications@github.com> wrote:
> 
> In bazooka-log.go:
> 
> >  		go s.serve(conn)
> >  	}
> >  }
> >  
> > -func (s *server) serve(conn net.Conn) {
> > -	c := NewClient(conn, s.buffer, s.timeout, s.subc, s.unsubc)
> > +func (s *server) serve(conn net.Conn) (err error) {
> Does this method need to return anything at all, as it is called asynchronously anyway, or is the returned error important for testing purposes? Also like to avoid named return values, if possible.
> 
> —
> Reply to this email directly or view it on GitHub.