use ignores and fix some logic maybe