Ok. I'm going to take off the logging safeties and instead raise correctly so I can root cause.


From: Victor Lowther [mailto:notifications@github.com]
Sent: Wednesday, November 20, 2013 02:04 PM Central Standard Time
To: crowbar/barclamp-crowbar <barclamp-crowbar@noreply.github.com>
Cc: Hirschfeld, Rob
Subject: Re: [barclamp-crowbar] BDD Test Coverage Improvement (just 1 left!) [1/3] (#771)


In crowbar_framework/app/models/run.rb:

> @@ -40,7 +40,7 @@ def self.cleanup
>      Run.transaction do
>        ActiveRecord::Base.connection.execute("LOCK TABLE runs")
>        deletable.each do |j|
> -        Rails.logger.info("Run: Deleting #{j.node_role.name}: state #{j.node_role.state}")
> +        Rails.logger.info("Run: Deleting #{j.node_role.name}: state #{j.node_role.state}") unless j.node_role.nil?


I would rather not merge this until we figure out why these checks are needed for BDD and not for production. noderoles should not disappear without good reason.

—
Reply to this email directly or view it on GitHub<https://github.com/crowbar/barclamp-crowbar/pull/771/files#r7803680>.