Martin and Hartmut,

I'd added a few things (fixes for PyQt4.uic) to this pull request -- what
do you think? If you'd prefer to omit the hookutils.py modifications, I can
keep those locally and resubmit a modified request; the other fixes are
(IMHO) important.

Bryan


On Wed, Nov 27, 2013 at 10:41 PM, Bryan A. Jones <bjones@ece.msstate.edu>wrote:

> Martin and Hartmut,
>
> Thanks for the feedback. I'm using the argument in the hook for an
> application employing PyInstaller to generate a binary. Reasons to include
> this in PyInstaller:
>
> 1. This allows PyInstaller to better support the standard library
> (pkgutil.iter_modules and, most likely, other functions in the pkgutil
> module) by providing a standardized way to place source files in the binary.
> 2. Better PyQt support: I may use it to copy across all files in
> PyQt4.uic.widget-plugins in hook-PyQt4.uic, since users may place their
> custom widgets there. That code is still in development, so I haven't
> created a push request for it yet.
>
> I'll certainly clean up my code for follow PEP8. Thanks for the pointer.
>
> Bryan
>
>
> On Wed, Nov 27, 2013 at 1:17 PM, Hartmut Goebel <notifications@github.com>wrote:
>
>> In PyInstaller/hooks/hookutils.py:
>>
>> > @@ -682,7 +682,7 @@ def collect_submodules(package):
>> >  PY_IGNORE_EXTENSIONS = set(['.py', '.pyc', '.pyd', '.pyo', '.so', 'dylib'])
>> >
>> >
>> > -def collect_data_files(package):
>> > +def collect_data_files(package, allow_py_extensions = False):
>>
>> And please follow PEP8: no spaces around "=" in parameters.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/pyinstaller/pyinstaller/pull/95/files#r7966983>
>> .
>>
>
>
>
> --
> Bryan A. Jones, Ph.D.
> Associate Professor
> Department of Electrical and Computer Engineering
> 231 Simrall / PO Box 9571
> Mississippi State University
> Mississippi state, MS 39762
> http://www.ece.msstate.edu/~bjones
> bjones AT ece DOT msstate DOT edu
> voice 662-325-3149
> fax 662-325-2298
>
> Our Master, Jesus Christ, is on his way. He'll show up right on
> time, his arrival guaranteed by the Blessed and Undisputed Ruler,
> High King, High God.
> - 1 Tim. 6:14b-15 (The Message)
>



-- 
Bryan A. Jones, Ph.D.
Associate Professor
Department of Electrical and Computer Engineering
231 Simrall / PO Box 9571
Mississippi State University
Mississippi state, MS 39762
http://www.ece.msstate.edu/~bjones
bjones AT ece DOT msstate DOT edu
voice 662-325-3149
fax 662-325-2298

Our Master, Jesus Christ, is on his way. He'll show up right on
time, his arrival guaranteed by the Blessed and Undisputed Ruler,
High King, High God.
- 1 Tim. 6:14b-15 (The Message)