xe console should not be hidden command

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
CA-96886: Fix race for a PCI device by multiple starting VMs

When multiple simultaneously starting VMs try to grab the same PCI device, only one of them
may get it, and the others must fail to start. However, xapi considers a PCI device "assigned"
to a VM only when the VM has started and the device has been made available to the VM, which
is some time after xapi has asked xenopsd to start the VM and give it the PCI device. This means
that there is a window during which multiple VM may be given the same device.

This patch attempts to resolve this by temporarily reserving a PCI device for a VM in xapi, before telling xenopsd to start the VM.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
XOP-229: Make xenopsd using keep_alive.

Signed-off-by: Jerome Maloberti <jerome.maloberti@citrix.com>
XOP-229: Make rrd_updates uses keep_alive=true.

Signed-off-by: Jerome Maloberti <jerome.maloberti@citrix.com>
CA-98535: Fix VDI.create

The other_config, shareable, tags and xenstore_data fields are now set
to their correct values when creating a VDI.

Signed-off-by: John Else <john.else@citrix.com>
Whitespace: xapi_sr.ml

$ camlp4o -printer o -no_comments ocaml/xapi/xapi_srl | md5sum
7760aa8c3f302bc5ebca565b2c83b483  -
$ git checkout HEAD^
$ camlp4o -printer o -no_comments ocaml/xapi/xapi_sr.ml | md5sum
7760aa8c3f302bc5ebca565b2c83b483  -

Signed-off-by: John Else <john.else@citrix.com>
CA-98633: Raise SR_UUID_EXISTS in SR.introduce if an SR with the same UUID already exists.

Signed-off-by: John Else <john.else@citrix.com>
PR-1510: LACP timeout, aggregator/actor parameters settable

LACP timeout, aggregator/actor parameters are now settable through XenAPI and
CLI. New bond parameters are lacp-time, lacp-aggregator-key and lacp-actor-key.

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
Refactor Network_utils.Ovs to functorize vsctl commands for testing

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
PR-1510: add unit tests for LACP params setting

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
PR-1510: bond parameters either have defaults or are omitted

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
PR-1510: More test cases

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
Remove unecessary debug line

Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
Simplify network module for xapi -> networkd calls

Also move it from ocaml/network to ocaml/xapi for consistency.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Add network.mli to fix namespace collision

Signed-off-by: John Else <john.else@citrix.com>
Stop using Netdev module in Nm

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Stop using Netdev module in Xapi_pif

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Stop using Netdev module in Create_misc

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Stop using Netdev module in Helpers

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Stop using Netdev module in Mtc

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>