Revert "Revert "(maint) Replace rspec >= 2.11 expect(foo).to with foo.should""

This reverts commit b4097871e84d7a7b3441130289c594aee859af74.
Merge branch 'maint-rspec_2.9_expectations'

This ensures that GH-423 uses 2.9 expectations since jenkins.puppetlabs.com
uses that version of rspec for testing.
Remove redundant attr_accessor :interpreter

To prevent warnings. Both reader and writer are defined at line 417.
Merge pull request #441 from jaeheung90/debug_resolution.rb_warning

Remove redundant attr_accessor :interpreter
Break out code to parse sysfs into separate function
(#19249) Split ProcessorCount to separate TotalProcessorCount and ActiveProcessorCount facts
move sysfs_proc_count to util/processor.rb
change processorcount to be same as totalprocessorcount, probably will remove totalprocessorcount
Refactored to eliminate code duplication
(maint) refactor processor specs, test sysfs fallback
(maint) downcase processorcount fact names
(maint) Refactor specs for totalprocessorcount
(maint) refactor shared processorcount/totalprocessorcount behavior
Merge branch 'pull-437'

This closes GH-437
(#20229) Fix per-interface netmask_* facts with net-tools 1.60

Without this patch the interface specific facts for the netmask are not
correctly parsed on systems with net-tools 1.60 or later, such as
Archlinux.

This patch addresses the problem by adjusting the regular expression to
take into account the new format of the ifconfig command.

This patch is specific to the netmask_* facts and does not affect the
behavior of the general `netmask` fact.
(#20229) Fix netmask fact with Linux net-tools 1.60

Without this patch the netmask fact does not return a value on Archlinux
because of the new format of the net-tools package.

This patch addresses the problem by updating the regular expressions for
the netmask fact.  Both the old format and the new format are covered by
the regular expression now.
(maint) De-duplicate parses RSpec alias

Adrien pointed out the duplication of

    RSpec.configure do |config|
      config.alias_it_should_behave_like_to :example_behavior_for, "parses"
    end

in both of the interfaces_spec file and the netmask_spec file.  This
patch removes the duplicate statements and places them in a shared file
required by both example specs.
Merge pull request #432 from jeffmccune/fix_netmask_scanner

(#20229) Fix per-interface netmask_* facts with net-tools 1.60
(Maint) Remove whitespace errors
(#20938) Ignore stderr from domain commands

Previously, when the hostname of a system is in a messed up stated, the
hostname and dnsdomainname commands would output warning messages to
stderr. The facter command execution system does not capture this, and
so the stderr output ends up making it all the way out to the caller and
likely to the user, as is the case for puppet when using facter.

This commit takes the simple approach of redirecting the error output to
/dev/null, which should be sufficient for the platforms that use these
commands (non-windows).
(maint) Remove duplication from selinux facts

Prior to this commit, the selinux fact had code duplication. This commit
abstracts this duplication to a hash of fact name and label.
(Maint) Remove duplication in domain tests

The tests were full of duplication around what commands would be
executed and how. This works toward removing the duplication and even
combines two tests together to provide a less implementation specific
assertion about the precedence of the resolv.conf data.