Jon jump on skype I'll talk about it. I'm not happy about it either - It's
ugly but it's allowed me to understand what the next version should be
like. I'm sorry you westled with this.


On Tue, Jul 16, 2013 at 2:10 PM, jonlemmon <notifications@github.com> wrote:

> In spec/extras/queries/visible_discussions_spec.rb:
>
> > @@ -1,251 +1,169 @@
> >  require 'spec_helper'
>
> Actually I hate to say it, but after wrestling with this spec and query
> object all today, I think this new implementation is much less clear and
> harder to manage.
>
> I'm very upset with both of these files right now and I really wish you
> could have left the existing structure and merged your work into it...
> everything is a shit-storm now and I hate it.
>
> I'll get over it though... I just really think these two files are the
> worst part of this and desperately need refactoring. The query object has
> bugs, and every time I add a test to this spec file to try and solve them
> everything just gets more vague and unclear.
>
> #rant-finished. Sorry about that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/loomio/loomio/pull/851/files#r5208169>
> .
>