working on modal.js