The reason it's defined where it is now is that it could get translated to other languages.  Don't care in the short term; might want it there later.


From: Adobe <kenton@adobe.com<mailto:kenton@adobe.com>>
Date: Monday, April 8, 2013 4:22 PM
To: adobe-research/brackets <reply@reply.github.com<mailto:reply@reply.github.com>>
Cc: Adobe <kenton@adobe.com<mailto:kenton@adobe.com>>
Subject: Re: [brackets] Added Goto Definition. (#11)


I might as well just define it directly in main.js — it doesn't get used anywhere else, and it's just a string.


From: Erik Tierney <notifications@github.com<mailto:notifications@github.com>>
Reply-To: adobe-research/brackets <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, April 8, 2013 4:09 PM
To: adobe-research/brackets <brackets@noreply.github.com<mailto:brackets@noreply.github.com>>
Cc: Adobe <kenton@adobe.com<mailto:kenton@adobe.com>>
Subject: Re: [brackets] Added Goto Definition. (#11)


In src/nls/root/strings.js:

> @@ -229,6 +229,7 @@ define({
>      "CMD_QUICK_OPEN"                      : "Quick Open",
>      "CMD_GOTO_LINE"                       : "Go to Line",
>      "CMD_GOTO_DEFINITION"                 : "Go to Definition",
> +    "CMD_JUMPTO_DEFINITION"               : "Jump to Definition",


I don't think we should be modify anything outside of our extension - can this literal go in HintUtils.js in the code hint extension?

—
Reply to this email directly or view it on GitHub<https://github.com/adobe-research/brackets/pull/11/files#r3701941>.