Agree - PR was probably premature! Did on plane and it works :-)

On 29 October 2013 at 12:07:13, James Cox (notifications@github.com) wrote:

In ede_query.coffee:

> +
> +  xml = fs.readFileSync('ede_sample.xml','utf8') # Replace with request to actual feed
> +
> +  parseString(xml,(err,result)->  
> +    if err?  
> +      console.error err
> +      throw err
> +      res.send(500, "Couldn't parse XML for #{url}")
> +    try
> +      indicatorData = indicatorate(indicatorCode, result)
> +      res.send(200, JSON.stringify(indicatorData))
> +    catch e
> +      console.error e.stack
> +      res.send(500, e.toString())
> +  )
> +  return
This is a bit weird, better to create a named function like 'querySOAPUrl' and not call it.

—
Reply to this email directly or view it on GitHub.