Fix a number of problems with destructuring of arguments
https://bugs.webkit.org/show_bug.cgi?id=123357

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This renames the destructuring node's emitBytecode to bindValue
in order to remove the existing confusion over what was happening.

We then fix an incorrect fall through in the destructuring arguments
logic, and fix the then exposed bug where we placed the index rather
than value into the bound property.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::ArrayPatternNode::bindValue):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ObjectPatternNode::bindValue):
(JSC::BindingNode::bindValue):
* parser/Nodes.h:

LayoutTests:

Add additional testing

* js/destructuring-assignment-expected.txt:
* js/script-tests/destructuring-assignment.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Merge revision columns in flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123360

Reviewed by Simon Fraser.

Merge revision numbers into one cell separated by /, and clearly label them as "latest revisions".
Also add colors for missing & audio failures so that they won't be an empty cell.

* public/index.html:
(TestResultsView._createTestResultHeader): Create a single th for the list of repository names.
(TestResultsView._createTestResultRow): Use single td for all revision numbers.
* public/js/build.js:
(.this.formattedRevision): Don't prefix revision numbers with '@' when we're not in the tooltip.
* public/main.css:
(.resultsTable .AUDIO a): Added.
(.resultsTable .MISSING a): Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363

Reviewed by Simon Fraser.

Sort builders and tests by their name in each pane.

* public/index.html:
(TestResultsView._populateTestPane): Lexicologically sort builders by their name.
(TestResultsView._sortObjectsByName): Added.
(TestResultsView._populateBuilderPane): Lexicologically sort builders by their name.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Win] Javascript crash with DFG JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=121001

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Geoffrey Garen.

On windows, using register GPRInfo::regT0 as parameter to e.g. JIT::storeDouble(..., GPRInfo::regT0)),
results in a call to JIT::storeDouble(FPRegisterID src, const void* address),
where the address parameter gets the value of GPRInfo::regT0, which is 0 (eax on Windows).
This causes the register to be written to address 0, hence the crash.

* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::storeDouble): Assert if we try to generate code which writes to a null pointer.
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Use address in regT0 as parameter.
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DatabaseManager's ProposedDatabases need to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=123313.

Reviewed by Geoffrey Garen.

No new tests.

* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
* Modules/webdatabase/DatabaseManager.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Command+Click on url(…) should go to image not source line
https://bugs.webkit.org/show_bug.cgi?id=123362

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-25
Reviewed by Timothy Hatcher.

CodeMirror changed "url" from being type "variable-2" to "string-2".

* UserInterface/CodeMirrorAdditions.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager
https://bugs.webkit.org/show_bug.cgi?id=123361

Reviewed by Timothy Hatcher.

Created a test to check that WebInspector.DOMTree.Event.ContentFlowWasAdded and
WebInspector.DOMTree.Event.ContentFlowWasRemoved are dispatched when a flow is added
and removed.

* http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.assert): Similar to InspectorTest.log, but also takes a boolean and prefixes the message
with "FAIL" or "PASS" depending on the value.
(InspectorTest.importInspectorScripts): Added the required CSS Agent scripts to enable the flow thread events.
* inspector-protocol/model/content-flow-list-expected.txt: Added.
* inspector-protocol/model/content-flow-list.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Mavericks results with MountainLion variants.

* platform/mac-mountainlion/fast/repaint/search-field-cancel-expected.txt: Added.
* platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
* platform/mac-mountainlion/fast/text/international/cjk-segmentation-expected.txt: Added.
* platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
* platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
* platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158064 268f45cc-cd09-0410-ab3c-d52691b4dbfc