Totally. That's next on my list, at least controller tests.

> On Nov 20, 2013, at 6:08 PM, Quinn Shanahan <notifications@github.com> wrote:
> 
> In app/models/user.rb:
> 
> >    end
> >  
> >    # def authenticate
> > -  def self.authenticate params
> > -    user   = User.find_by_email(params[:email])
> > -    user ||= User.find_by_username(params[:email])
> > +  def self.authenticate(params)
> > +    user = User.find_by_email(params[:email]) || User.find_by_username(params[:email])
> Let's add tests before modifying business logic (even though it is obviously equivalent)
> 
> —
> Reply to this email directly or view it on GitHub.