Hi Ali,

I think I have concatenated it as strings at multiple locations.

Shall I replace every such log as below:

logger.loglevel(String arg 0 )

with

logger.loglevel(String arg 0, Object arg 1)

Thanks
Sumanth


On Thu, Feb 21, 2013 at 9:47 AM, Ali Al-Shabibi <notifications@github.com>wrote:

> In src/org/flowvisor/classifier/FVClassifier.java:
>
> > @@ -106,7 +111,7 @@ public FVClassifier(FVEventLoop loop, SocketChannel sock) {
> >  			this.msgStream = new FVMessageAsyncStream(sock, this.factory, this,
> >  					this.stats);
> >  		} catch (IOException e) {
> > -			FVLog.log(LogLevel.CRIT, this, "IOException in constructor!");
> > +			logger.error(this.getName()+"IOException in constructor!");
>
> When concatenating the log message it would better to pass every parameter
> into the Objects.... rather than concatenating the string which is
> inefficient.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/OPENNETWORKINGLAB/flowvisor/pull/173/files#r3102732>.
>
>