Small detail really, but for what it worth I would go for code clarity.
It's up to you ;)

On Sat, Jan 5, 2013 at 4:19 PM, Simon Coffey <notifications@github.com>wrote:

> In sunspot/lib/sunspot/adapters.rb:
>
> > @@ -146,6 +158,16 @@ def index_id_for(class_name, id) #:nodoc:
> >          def instance_adapters #:nodoc:
> >            @instance_adapters ||= {}
> >          end
> > +
> > +        def for_ancestors_of(clazz) # :nodoc:
> > +          clazz.ancestors.drop(1).each do |ancestor_class|
>
> Because Class#ancestors includes the class it's invoked on as its first
> element. It's not important really, just saves one cycle through the loop.
> Happy to drop it if you think it's unclear.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sunspot/sunspot/pull/322/files#r2558331>.
>
>



-- 
Mauro Asprea

E-Mail: mauroasprea@gmail.com
Mobile: +34 654297582
Skype: mauro.asprea