data provider test improved