I can create a KernelManager ABC in a subsequent PR.  What else needs to be
done to finish this one up?  Do we want the BlockingKernelManager
subclassing to be cleaned up?  There is other work blocked on this PR now,
so it would be good to finish it up.  But let's first figure out exactly
what needs to be done for this to go in (maybe make a task list!)


On Tue, Jan 15, 2013 at 3:43 PM, Evan Patterson <notifications@github.com>wrote:

> In IPython/inprocess/kernelmanager.py:
>
> > +        self._pause = True
> > +
> > +    def unpause(self):
> > +        """ Unpause the heartbeat. """
> > +        self._pause = False
> > +
> > +    def is_beating(self):
> > +        """ Is the heartbeat running and responsive (and not paused). """
> > +        return not self._pause
> > +
> > +
> > +#-----------------------------------------------------------------------------
> > +# Main kernel manager class
> > +#-----------------------------------------------------------------------------
> > +
> > +class InProcessKernelManager(HasTraits):
>
> To be clear, the shared base class is useful only indicating shared
> interface; there is no implementation to be shared here. (If I were writing
> ETS code, I would use an Interface for this). Given that, the issue does
> not seem especially pressing. Besides, @ellisonbg<https://github.com/ellisonbg>has already indicated his desire to work on this after the merge.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipython/ipython/pull/2724/files#r2658749>.
>
>



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com