Heh.  At one point there was probably a println in between those lines, or
I thought there would soon be one.


On Mon, Aug 19, 2013 at 10:16 AM, Tim Olsen <notifications@github.com>wrote:

> In v2/logger.go:
>
> > +}
> > +
> > +func containsAnyIgnoredFilename(s string) bool {
> > +	for _, ign := range ignoredFileNames {
> > +		if strings.Contains(s, ign)  {
> > +			return true
> > +		}
> > +	}
> > +	return false
> > +}
> > +
> > +func nonSloggerCaller() (pc uintptr, file string, line int, ok bool) {
> > +	for skip := 0; skip < 100; skip++ {
> > +		a,b,c,ok := runtime.Caller(skip)
> > +		shouldBeIgnored := containsAnyIgnoredFilename(b)
> > +		if !ok || !shouldBeIgnored  {
>
> cc'ing @bardbloom <https://github.com/bardbloom> again. Yes, in fact if
> we remove the shouldBeIgnored variable and move the
> containsAnyIgnoreFilename call into the if, the short-circuiting ||
> operator will have the same effect.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/10gen-labs/slogger/pull/1/files#r5842933>
> .
>