Agree. StmtTableScan is more concise.


On Mon, Oct 14, 2013 at 5:22 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/planner/StmtCatalogCache.java:
>
> > +package org.voltdb.planner;
> > +
> > +import org.voltdb.catalog.Table;
> > +
> > +/**
> > + * StmtCatalogCache caches Catalog data related to a given instance of a table from a statement
> > + */
> > +public class StmtCatalogCache {
> > +
> > +    public static final int NULL_ALIAS_INDEX = -1;
> > +    // Catalog table
> > +    public Table m_table;
> > +    // table alias
> > +    public String m_tableAlias;
> > +
> > +}
>
> This name confused me. It seems like more of an entry IN a cache than a
> cache itself. Maybe better something like: "StmtTableScan"?
> "CachedTableForStmt"?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/5/files#r6956158>
> .
>