I’d be okay with this. It was a requested feature that we expose the iscsi_ip_address variable to be configurable. I’ve committed the change with some doc clarification.

From: Robert Starmer [mailto:notifications@github.com]
Sent: Tuesday, July 23, 2013 9:56 AM
To: CiscoSystems/grizzly-manifests
Cc: Don Talton (dotalton)
Subject: Re: [grizzly-manifests] add cinder standalone support (#93)


In manifests/site.pp.example:

> @@ -194,6 +195,21 @@ $cinder_compute_enabled        = true

>  # The cinder storage driver to use. Default is 'iscsi'.

>  $cinder_storage_driver         = 'iscsi'

>

> +# the public IP address iSCSI should use

> +# this uses facter for address info. Ex. $ipaddress_eth0, etc.

> +$cinder_iscsi_ip = $ipaddress_eth2

> +

> +# cinder storage node definitions
Even so, why would you default it to something other that $::ipaddress? It seems that this example is making assumptions about connectivity that may not be appropriate. On Jul 23, 2013, at 9:23 AM, Donald Talton <notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>>> wrote: In manifests/site.pp.example:
@@ -194,6 +195,21 @@ $cinder_compute_enabled = true # The cinder storage driver to use. Default is 'iscsi'. $cinder_storage_driver = 'iscsi' +# the public IP address iSCSI should use +# this uses facter for address info. Ex. $ipaddress_eth0, etc. +$cinder_iscsi_ip = $ipaddress_eth2 + +# cinder storage node definitions
Ian, it's a facter variable, so it will be unique for the node when the catalog gets compiled. — Reply to this email directly or view it on GitHub<https://github.com/CiscoSystems/grizzly-manifests/pull/93/files#r5349237>.

—
Reply to this email directly or view it on GitHub<https://github.com/CiscoSystems/grizzly-manifests/pull/93/files#r5350159>.