On 10.12.2013, at 13:54, Enrico Siragusa wrote:


In core/include/seqan/index/index_wotd.h:

> @@ -2057,6 +2057,13 @@
>               return true;
>       }
>
> +     //TODO(singer): this is a temporary fix  -> move to index_shims.h


  1.  I thought @weese<https://github.com/weese> had to review this, not @holtgrewe<https://github.com/holtgrewe>

Yes, but Dave is not here and the tests do not run through

  1.  Does the problem occur only with Wotd indexCreate()?

Yes

  1.  Why don't you just move it in index_shims.h and remove the TODO?

Because I don't know it my fix is appropriate. I already wrote Dave an Email and added the TODO. Only if my fix is the solution it should be moved.

—
Reply to this email directly or view it on GitHub<https://github.com/seqan/seqan/pull/92/files#r8230559>.

Jochen Singer
Institute of Computer Science
Algorithmic Bioinformatics Working Group

Freie Universität Berlin
Takustr. 9, 14195 Berlin
Phone +49 30 838 75228, Room K25