C++ readability review for rouslan@

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/19486002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216350 0039d316-1c4b-4281-b951-d872f2087c98
Remove unused variable declaration.

This issue was found by a linter.

R=dewittj@chromium.org, mukai@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/22325008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216351 0039d316-1c4b-4281-b951-d872f2087c98
Restrict the reset before decode case to Intel platforms.

The hang on Exynos is a known problem.

BUG=chromium:269005
TEST=The test can pass on Arm (but there are still other issues).

Review URL: https://chromiumcodereview.appspot.com/22398003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216352 0039d316-1c4b-4281-b951-d872f2087c98
Remove views/ime/input_method_win.{h,cc}

These files are no longer used by anyone.

BUG=246516
TBR=nona@chromium.org

Review URL: https://codereview.chromium.org/22479004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216353 0039d316-1c4b-4281-b951-d872f2087c98
Docked area should have a drawn background visually separating it from the workspace

BUG=267582

Review URL: https://chromiumcodereview.appspot.com/22483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216354 0039d316-1c4b-4281-b951-d872f2087c98
Revert 216345 "Move ExtensionError to extensions/, add error limits"

It leaks memory:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/24926/steps/memory%20test%3A%20unit/logs/stdio

Leak_DefinitelyLost
663 (264 direct, 399 indirect) bytes in 3 blocks are definitely lost in loss record 33,024 of 38,445
  operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140)
  extensions::(anonymous namespace)::CreateNewRuntimeError(bool, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&) (chrome/browser/extensions/error_console/error_console_unittest.cc:51)
  extensions::ErrorConsoleUnitTest_AddAndRemoveErrors_Test::TestBody() (chrome/browser/extensions/error_console/error_console_unittest.cc:80)


> Move ExtensionError to extensions/, add error limits
> 
> Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
> Limit the number of errors stored per extension to 100.
> Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.
> 
> BUG=21734
> 
> Review URL: https://chromiumcodereview.appspot.com/21609003

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/22585003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216355 0039d316-1c4b-4281-b951-d872f2087c98
Revert 216346 "rAc: Don't show "save in chrome" checkbox when Lo..."

> rAc: Don't show "save in chrome" checkbox when Loading... screen visible.
> 
> BUG=255710
> 
> Review URL: https://chromiumcodereview.appspot.com/22300012

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/22638004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216356 0039d316-1c4b-4281-b951-d872f2087c98
Updating trunk VERSION from 1590.0 to 1591.0

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216360 0039d316-1c4b-4281-b951-d872f2087c98
Modify id of 'cygwin' repo
Update third_party/cld/OWNERS

add hajimehoshi

BUG=none
TEST=none
NOTRY=true
R=mad@chromium.org

Review URL: https://codereview.chromium.org/22521005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216365 0039d316-1c4b-4281-b951-d872f2087c98
Automated Commit: Committing new LKGM version 4509.0.0 for chromeos.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216369 0039d316-1c4b-4281-b951-d872f2087c98
Node Frame is always focusable

Fix rogerwang/node-webkit#933
Settings: blink change to conform css spec broke layout of home page url

inline-block baseline with overflow property being computed value is
the bottom margin edge now. The css for #home-page-url hits the case.

BUG=268242
TEST=manual
R=estade@chromium.org

Review URL: https://codereview.chromium.org/22385002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216370 0039d316-1c4b-4281-b951-d872f2087c98
Make simple cache index take hashes in rather than key strings.

The index was re-hashing keys that were already hashed.

This CL also adds an ImmutableArray helper class for testing.

BUG=257616
R=gavinp@chromium.org, pasko@chromium.org

Review URL: https://codereview.chromium.org/21037003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216372 0039d316-1c4b-4281-b951-d872f2087c98
Revert 216372 "Make simple cache index take hashes in rather tha..."

> Make simple cache index take hashes in rather than key strings.
> 
> The index was re-hashing keys that were already hashed.
> 
> This CL also adds an ImmutableArray helper class for testing.
> 
> BUG=257616
> R=gavinp@chromium.org, pasko@chromium.org
> 
> Review URL: https://codereview.chromium.org/21037003

TBR=pliard@chromium.org

Review URL: https://codereview.chromium.org/22458009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216373 0039d316-1c4b-4281-b951-d872f2087c98
Fix build errors on Mac
Remove a 'content-updated' event in DirectoryTree on Files.app

A 'content-updated' event was used to notify a change of the directory tree content, in order to hide the tree if the current volume doesn't have any folder. But now, the tree is only for Google Drive volume, which always has a folder (My Drive, Offline, Recent, ...), so that it's never hidden by 'content-update' event. It's unnecessary now, and we can remove it.

BUG=269903
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216375 0039d316-1c4b-4281-b951-d872f2087c98
[cros] Various fixes for Chrome OS supervised user UI

* Creation flow > intro screen content updated
* String: [Creating profile...] > [Creating supervised user]
* String [Authenticating...] > [Authenticating]
* String: [Create an name] > [Create a name]
* First-run notification/tray info string
* User manager display email preserves dots.
* Manager email is shown on blocked info page

BUG=267002,267846,268788,268938,265548,268988,269150,268982,268271
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22144003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216376 0039d316-1c4b-4281-b951-d872f2087c98
Add drive::FileSystem::GetFileByPathForSaving().

This is a part of the effort to enable Drive in the Save-As dialog of
Chrome OS for every call site. For that, we need to care about existing
callers that just simply write to local file paths returned by the dialog.

By calling the newly added method, Drive file system will return a local
cache whose modification is monitored for syncing.

BUG=140425

Review URL: https://chromiumcodereview.appspot.com/22335004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216377 0039d316-1c4b-4281-b951-d872f2087c98
Rename WebFont.LoadTime.* histograms to WebFont.DownloadTime.*

Change the histogram names since the definition of the histogram changed in
https://src.chromium.org/viewvc/blink?view=rev&revision=155601

BUG=237058
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22387004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216378 0039d316-1c4b-4281-b951-d872f2087c98