parameters now working